2021-03-03 03:35 CET
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002432Frama-CKernelpublic2019-03-20 17:272019-07-05 11:41
ReporterStevendeo 
Assigned Tovirgile 
PrioritylowSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
Product VersionFrama-C 18-Argon 
Target VersionFixed in VersionFrama-C 19-Potassium 
Summary0002432: Attributes of size 1 are rejected
DescriptionAttributes are parsed by Extlib.strip_underscore that removes underscores before and after a string. However, the function always returns an empty string when the size of the input is 1. The attribute is then rejected.
The error is not raised in Chlorine.
Steps To Reproduceframa-c foo.c
Additional InformationHere is a possible bug fix

let strip_underscore s =
  let l = String.length s in
  if l = 1
  then
    match s with
      "_" -> ""
    | _ -> s
  else
    let rec start i =
      if i >= l then l-1
      else if s.[i] = '_' then start (i + 1) else i
    in
    let st = start 0 in
    if st = l - 1 then ""
    else begin
      let rec finish i =
        (* We know that we will stop at >= st >= 0 *)
        if s.[i] = '_' then finish (i - 1) else i
      in
      let fin = finish (l - 1) in
      String.sub s st (fin - st + 1)
    end
TagsNo tags attached.
Attached Files
  • c file icon foo.c (52 bytes) 2019-03-20 17:27 - 
    int main(){
  int __attribute((t)) x;
  return 0;
}
    c file icon foo.c (52 bytes) 2019-03-20 17:27 +

-Relationships
+Relationships

-Notes

~0006762

virgile (developer)

2019-04-09 17:27

 Actually, the main issue is returning l-1 when no non-underscore character is found. It should return l (and the test for emptiness be updated accordingly). This is fixed in dev branch and will appear in the next Frama-C release. Thanks for the report.
+Notes

-Issue History
Date Modified Username Field Change
2019-03-20 17:27 Stevendeo New Issue
2019-03-20 17:27 Stevendeo File Added: foo.c
2019-04-09 17:27 virgile Note Added: 0006762
2019-04-09 17:28 virgile Status new => resolved
2019-04-09 17:28 virgile Fixed in Version => Frama-C 19-Potassium
2019-04-09 17:28 virgile Resolution open => fixed
2019-04-09 17:28 virgile Assigned To => virgile
2019-07-05 11:41 signoles Status resolved => closed
+Issue History