View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
---|---|---|---|---|---|---|---|---|---|
0001180 | Frama-C | Kernel | public | 2012-05-16 15:22 | 2012-09-19 17:16 | ||||
Reporter | mehdi | ||||||||
Assigned To | signoles | ||||||||
Priority | normal | Severity | minor | Reproducibility | always | ||||
Status | closed | Resolution | fixed | ||||||
Product Version | Frama-C Nitrogen-20111001 | ||||||||
Target Version | Fixed in Version | Frama-C Oxygen-20120901 | |||||||
Summary | 0001180: Port to OCamlgraph 1.8.2 | ||||||||
Description | Hi, Recent OCamlgraph 1.8.2 has a non backward compatible change. The change is described in OCamlgraph's changelog as: o Topological: fix bug when a cycle depends on another cycle. That breaks compatibility: the input graph must implement Sig.COMPARABLE instead of Sig.HASHABLE The attached patch make Frama-c compile (and run properly :)) with OCamlgraph 1.8.2. I wasn't sure whether I should use Pervasives.compare or Datatype.Int.compare. I noticed that the latter is more used so I preferred it over the standard one. Comments on this patch are welcome. The patch is rather straightforward and easy and I'm (almost) sure you already fixed that but maybe other Frama-C users will need it… and I'm sharing it here. Regards, Mehdi | ||||||||
Tags | No tags attached. | ||||||||
Attached Files |
|
![]() |
|
signoles (manager) 2012-05-16 15:40 |
Hi Mehdi, Thanks for your patch. It is correct. As you guess, the current SVN version of Frama-C is already up-to-date according to ocamlgraph 1.8.2. Actually, we found the bug in OcamlGraph's topological with a Frama-C's case study: services computed by plug-in "syntactic callgraph" were sometimes wrong in Frama-C Nitrogen (and older release) because of this bug. Julien |
![]() |
|||
Date Modified | Username | Field | Change |
---|---|---|---|
2012-05-16 15:22 | mehdi | New Issue | |
2012-05-16 15:22 | mehdi | File Added: 0007-Port-to-OCamlgraph-1.8.2.patch | |
2012-05-16 15:31 | signoles | Status | new => assigned |
2012-05-16 15:31 | signoles | Assigned To | => signoles |
2012-05-16 15:40 | signoles | Note Added: 0003017 | |
2012-05-16 15:40 | signoles | Status | assigned => resolved |
2012-05-16 15:40 | signoles | Resolution | open => fixed |
2012-09-19 17:15 | signoles | Fixed in Version | => Frama-C Oxygen-20120901 |
2012-09-19 17:16 | signoles | Status | resolved => closed |